Skip to content

Add support for project_api_key. - #32

Merged
Twixes merged 3 commits into
masterfrom
projectapikey
May 18, 2021
Merged

Add support for project_api_key. #32
Twixes merged 3 commits into
masterfrom
projectapikey

Conversation

@neilkakkar

@neilkakkar neilkakkar commented May 18, 2021

Copy link
Copy Markdown
Contributor

Fixes #31

This doesn't remove api_key yet, but supports both project_api_key and api_key.

@neilkakkar
neilkakkar requested a review from Twixes May 18, 2021 13:10
@neilkakkar
neilkakkar requested a review from mariusandra May 18, 2021 13:28

@mariusandra mariusandra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Twixes Twixes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix the reported issue, though still not great how we recommend the new param to users, but internally confusingly use the old one. Created #33 to keep track of this.

@Twixes
Twixes merged commit fd92502 into master May 18, 2021
@Twixes
Twixes deleted the projectapikey branch May 18, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

posthog.project_api_key doesn't work

3 participants